[PATCH] D71743: [TTI][ARM][MVE] Enable masked gathers from vector of pointers

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 23 08:30:16 PST 2019


dmgreen added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:611
+  /// still IR. Return true if legalised.
+  bool customLegalizeMaskedGather(IntrinsicInst *I, bool &ModifiedDT) const;
+
----------------
RKSimon wrote:
> Its unusual to put transformational methods inside TargetTransformInfo - that tends to be legality/cost checks, not IR transforms.
Oh yeah. We were thinking of the interleaved load lowering that we do, but now that I look again that happens in TLI. I had not realized.

Because of the amount of code this might turn into (and how long TLI is already), it might be better as a separate pass though.

We will look into this after the hols. Thanks for the comments.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71743/new/

https://reviews.llvm.org/D71743





More information about the llvm-commits mailing list