[PATCH] D71655: [MachineScheduler] Allow clustering mem ops with complex addresses

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 21 03:55:47 PST 2019


arsenm added a comment.

I've wanted this for a long time



================
Comment at: llvm/include/llvm/CodeGen/TargetInstrInfo.h:1262
+  /// passing into shouldClusterMemOps. On failure, return no operands at all.
+  virtual void getMemAddressOperands(const MachineInstr &MI,
+                                     SmallVectorImpl<const MachineOperand *> &AddrOps,
----------------
Why doesn't this one return bool for failure?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71655/new/

https://reviews.llvm.org/D71655





More information about the llvm-commits mailing list