[PATCH] D71655: [MachineScheduler] Allow clustering mem ops with complex addresses

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

> The old target hook TargetInstrInfo::getMemOperandWithOffset has been
>  renamed and split into three:
> 
> getMemBaseRegWithOffset: returns a base register plus byte offset,
>  default implementation calls...
> 
> getMemBaseOpWithOffset: returns a base operand (register or frame index)
>  plus byte offset, default implementation calls...
> 
> [...]

I could do the renaming and splitting into `getMemBaseRegWithOffset` and `getMemBaseOpWithOffset` as a preparatory patch if that would make the review easier. It's mechanical and uncontroversial (I think). The only reason for reintroducing the `getMemBaseRegWithOffset` variant (which is all we had prior to D54846 <https://reviews.llvm.org/D54846>, when it was called `getMemOpBaseRegImmOfs`) is that it simplifies some call sites.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71655/new/

https://reviews.llvm.org/D71655