[PATCH] D71816: [DAGCombiner] Add combine for (not (strict_fsetcc)) to create a strict_fsetcc with the opposite condition.
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Dec 22 19:27:38 PST 2019
craig.topper marked an inline comment as done.
craig.topper added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:7073
+ if (N0.hasOneUse()) {
+ // FIXME Can we handle multiples uses? Could we token factor the chain
+ // results from the new/old setcc?
----------------
pengfei wrote:
> Why we need consider cases more than one use? Isn't xor + setcc better that 2 setccs?
We generally try to increase parallelism and reduce latency. Two setccs can be done in parallel, while setcc+xor serializes the xor behind the setcc.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71816/new/
https://reviews.llvm.org/D71816
More information about the llvm-commits
mailing list