[PATCH] D71818: reland "[DebugInfo] Support to emit debugInfo for extern variables"

[Reid Kleckner via Phabricator via llvm-commits]

rnk added subscribers: rjmccall, rsmith.
rnk added a comment.

+ at rsmith @rjmccall 
For more meaningful feedback on the code structure.



================
Comment at: clang/include/clang/Sema/Sema.h:671-672
 
+  /// All the external declarations encoutered and used in the TU.
+  SmallVector<VarDecl *, 4> ExternalDeclarations;
+
----------------
This name seems a bit vague. This is a member of Sema, essentially a global variable, for this very corner-case feature (BPF). I'm not convinced that you couldn't have done this without changing Sema.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71818/new/

https://reviews.llvm.org/D71818