[PATCH] D71817: Fix LLVM tool --version build mode printing for MSVC

[Reid Kleckner via Phabricator via llvm-commits]

rnk marked an inline comment as done.
rnk added inline comments.


================
Comment at: llvm/lib/Support/CommandLine.cpp:2443
+# if defined(__OPTIMIZE__)
+#  define LLVM_IS_DEBUG_BUILD 0
+# else
----------------
MaskRay wrote:
> `LLVM_IS_OPTIMIZED_BUILD` looks like more appropriate?
> I thought the difference is between "optimized/non-optimized builds", not between "debug/non-debug builds".
I figured this whole feature exists to warn users when they are running tools built in debug mode, so I felt this was the better direction. But maybe I am biased, I develop with optimizations enabled. =P


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71817/new/

https://reviews.llvm.org/D71817