[llvm] 2d903cc - [AMDGPU] Fixes -Wrange-loop-analysis warnings
Mark de Wever via llvm-commits
llvm-commits at lists.llvm.org
Sun Dec 22 10:40:17 PST 2019
Author: Mark de Wever
Date: 2019-12-22T19:39:28+01:00
New Revision: 2d903cc9656d8b55d267ad21a2f21f63b9fcc3ab
URL: https://github.com/llvm/llvm-project/commit/2d903cc9656d8b55d267ad21a2f21f63b9fcc3ab
DIFF: https://github.com/llvm/llvm-project/commit/2d903cc9656d8b55d267ad21a2f21f63b9fcc3ab.diff
LOG: [AMDGPU] Fixes -Wrange-loop-analysis warnings
This avoids new warnings due to D68912 adds -Wrange-loop-analysis to -Wall.
Differential Revision: https://reviews.llvm.org/D71815
Added:
Modified:
llvm/lib/Target/AMDGPU/AMDGPUMachineCFGStructurizer.cpp
llvm/lib/Target/AMDGPU/AMDGPUUnifyMetadata.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUMachineCFGStructurizer.cpp b/llvm/lib/Target/AMDGPU/AMDGPUMachineCFGStructurizer.cpp
index 32246915fbd4..f61af5a27943 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUMachineCFGStructurizer.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUMachineCFGStructurizer.cpp
@@ -862,7 +862,7 @@ void LinearizedRegion::storeLiveOuts(RegionMRT *Region,
void LinearizedRegion::print(raw_ostream &OS, const TargetRegisterInfo *TRI) {
OS << "Linearized Region {";
bool IsFirst = true;
- for (const auto &MBB : MBBs) {
+ for (auto MBB : MBBs) {
if (IsFirst) {
IsFirst = false;
} else {
@@ -996,7 +996,7 @@ MachineBasicBlock *LinearizedRegion::getExit() { return Exit; }
void LinearizedRegion::addMBB(MachineBasicBlock *MBB) { MBBs.insert(MBB); }
void LinearizedRegion::addMBBs(LinearizedRegion *InnerRegion) {
- for (const auto &MBB : InnerRegion->MBBs) {
+ for (auto MBB : InnerRegion->MBBs) {
addMBB(MBB);
}
}
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUUnifyMetadata.cpp b/llvm/lib/Target/AMDGPU/AMDGPUUnifyMetadata.cpp
index d4401a22a1ad..281ae6d646e9 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUUnifyMetadata.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUUnifyMetadata.cpp
@@ -61,7 +61,7 @@ namespace {
return false;
MDNode *MaxMD = nullptr;
auto MaxVer = 0U;
- for (const auto &VersionMD : NamedMD->operands()) {
+ for (auto VersionMD : NamedMD->operands()) {
assert(VersionMD->getNumOperands() == 2);
auto CMajor = mdconst::extract<ConstantInt>(VersionMD->getOperand(0));
auto VersionMajor = CMajor->getZExtValue();
@@ -94,7 +94,7 @@ namespace {
return false;
SmallVector<Metadata *, 4> All;
- for (const auto &MD : NamedMD->operands())
+ for (auto MD : NamedMD->operands())
for (const auto &Op : MD->operands())
if (std::find(All.begin(), All.end(), Op.get()) == All.end())
All.push_back(Op.get());
More information about the llvm-commits
mailing list