[PATCH] D71807: [TableGen] Fixes -Wrange-loop-analysis warnings
Aaron Ballman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Dec 22 09:04:34 PST 2019
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a request to drop some top-level `const`s.
================
Comment at: llvm/utils/TableGen/AsmMatcherEmitter.cpp:3350
return false;
- for (const auto &Pair : zip(A, B)) {
+ for (const auto Pair : zip(A, B)) {
if (std::get<0>(Pair)->getName() < std::get<1>(Pair)->getName())
----------------
Drop the top-level `const`? (Same elsewhere)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71807/new/
https://reviews.llvm.org/D71807
More information about the llvm-commits
mailing list