[PATCH] D71732: Move the sysroot attribute from DIModule to DICompileUnit

Raphael Isemann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 22 06:48:51 PST 2019


teemperor added inline comments.


================
Comment at: llvm/bindings/go/llvm/dibuilder.go:120
 	RuntimeVersion int
+        SysRoot        string
 }
----------------
indentation seems of?


================
Comment at: llvm/bindings/go/llvm/dibuilder.go:148
 		/*DebugInfoForProfiling*/ C.LLVMBool(boolToCInt(false)),
+                sysroot
 	)
----------------
indentation seems of?


================
Comment at: llvm/include/llvm/IR/DebugInfoMetadata.h:1282
+  StringRef getSysRoot() const { return getStringOperand(9); }
+
 
----------------
double empty line?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71732/new/

https://reviews.llvm.org/D71732





More information about the llvm-commits mailing list