[PATCH] D71804: Fix -Wpessimizing-move warnings

[Stephan Dollberg via Phabricator via llvm-commits]

stephan.dollberg created this revision.
stephan.dollberg added a reviewer: lhames.
Herald added a project: LLVM.

Fixes a bunch of -Wpessimizing-move warnings as warned by gcc9.
`std::move`s in returns which prevents copy elision.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D71804

Files:
  llvm/include/llvm/ExecutionEngine/Orc/CompileOnDemandLayer.h
  llvm/include/llvm/ExecutionEngine/Orc/RPC/RPCUtils.h
  llvm/include/llvm/Support/TaskQueue.h


Index: llvm/include/llvm/Support/TaskQueue.h
===================================================================
--- llvm/include/llvm/Support/TaskQueue.h
+++ llvm/include/llvm/Support/TaskQueue.h
@@ -98,7 +98,7 @@
         IsTaskInFlight = true;
       }
     }
-    return std::move(F);
+    return F;
   }
 
 private:
Index: llvm/include/llvm/ExecutionEngine/Orc/RPC/RPCUtils.h
===================================================================
--- llvm/include/llvm/ExecutionEngine/Orc/RPC/RPCUtils.h
+++ llvm/include/llvm/ExecutionEngine/Orc/RPC/RPCUtils.h
@@ -1528,20 +1528,20 @@
             Args...)) {
       detail::ResultTraits<typename Func::ReturnType>::consumeAbandoned(
           std::move(Result));
-      return std::move(Err);
+      return Err;
     }
 
     if (auto Err = this->C.send()) {
       detail::ResultTraits<typename Func::ReturnType>::consumeAbandoned(
           std::move(Result));
-      return std::move(Err);
+      return Err;
     }
 
     while (!ReceivedResponse) {
       if (auto Err = this->handleOne()) {
         detail::ResultTraits<typename Func::ReturnType>::consumeAbandoned(
             std::move(Result));
-        return std::move(Err);
+        return Err;
       }
     }
 
Index: llvm/include/llvm/ExecutionEngine/Orc/CompileOnDemandLayer.h
===================================================================
--- llvm/include/llvm/ExecutionEngine/Orc/CompileOnDemandLayer.h
+++ llvm/include/llvm/ExecutionEngine/Orc/CompileOnDemandLayer.h
@@ -405,7 +405,7 @@
           if (auto Sym = LD.findSymbol(BaseLayer, MangledName, false))
             continue;
           else if (auto Err = Sym.takeError())
-            return std::move(Err);
+            return Err;
         }
 
         // Record all functions defined by this module.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71804.235040.patch
Type: text/x-patch
Size: 1792 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191222/fa47a4b8/attachment.bin>