[PATCH] D69798: Implement inlining of strictfp functions

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 22 02:08:23 PST 2019


uweigand added a comment.

In D69798#1793237 <https://reviews.llvm.org/D69798#1793237>, @kpn wrote:

> If FENV_ACCESS is ON and a function is called that expects it to be OFF then isn't that just plain undefined behavior? Unless it was changed since C99 I don't see how this is the compiler's problem to solve. And the compiler really shouldn't be changing the FP environment implicitly just because an arbitrary function was called, or we fell out of an FENV_ACCESS=ON scope, or whatever.


Yes, exactly.  The purpose of FENV_ACCESS is to **inform** the compiler about FP environment changes that the program (explicitly) performs;  under no circumstances is FENV_ACCESS intended to instruct the compiler to change the FP env on its own.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69798/new/

https://reviews.llvm.org/D69798





More information about the llvm-commits mailing list