[PATCH] D71677: [ms] [X86] Use "P" modifier on operands to call instructions in inline X86 assembly.

[Eric Astor via Phabricator via llvm-commits]

epastor marked 2 inline comments as done.
epastor added inline comments.


================
Comment at: llvm/test/CodeGen/X86/ms-inline-asm-PR44272.ll:15
+; CHECK: {{## InlineAsm Start|#APP}}
+; CHECK: call{{l|q}} func
+; CHECK: {{## InlineAsm End|#NO_APP}}
----------------
rnk wrote:
> I'd suggest matching for `{{call(l|q) func$}}` so that you don't accidentally match `callq func(%rip)`. Which makes me wonder, does `@PLT` appear here? The test uses no OS in the triple, which probably means ELF, so we probably use a PLT.
Thanks for that catch - completely missed that it'd match with `(%rip)` on the end.

Interestingly... no, no `@PLT` in this test. Not sure what's up with that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71677/new/

https://reviews.llvm.org/D71677