[PATCH] D71743: [TTI][ARM][MVE] Enable masked gathers from vector of pointers

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 21 10:06:12 PST 2019


RKSimon added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:611
+  /// still IR. Return true if legalised.
+  bool customLegalizeMaskedGather(IntrinsicInst *I, bool &ModifiedDT) const;
+
----------------
Its unusual to put transformational methods inside TargetTransformInfo - that tends to be legality/cost checks, not IR transforms.


================
Comment at: llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp:535
+  //  to expand.
+  if (dyn_cast<VectorType>(Ty)) {
+    return false;
----------------
isa<VectorType>(Ty)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71743/new/

https://reviews.llvm.org/D71743





More information about the llvm-commits mailing list