[PATCH] D71683: [ORC][EH] Deregister EH frames in MemoryManager dtor

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu closed this revision.
myhsu added a comment.

In D71683#1793713 <https://reviews.llvm.org/D71683#1793713>, @lhames wrote:

> In D71683#1793698 <https://reviews.llvm.org/D71683#1793698>, @myhsu wrote:
>
> > In D71683#1793661 <https://reviews.llvm.org/D71683#1793661>, @lhames wrote:
> >
> > > Actually, are you seeing this bug on ORC? Or just on MCJIT?
> >
> >
> > ORC, specifically ORCv2.
>
>
> Oh -- That's an ORCv2 bug. I have fixed that in 9f4f237e29e7 <https://reviews.llvm.org/rG9f4f237e29e7150dfcf04ae78fa287d2dc8d48e2>. Would you be able to apply that patch to your branch and see if it fixes your issue?


Yes, your patch fixed my issue. I also agreed that calling deregistration in RTDyldObjectLinkingLayer's dtor is more general/portable than my solution. So I guess I'm not going to proceed this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71683/new/

https://reviews.llvm.org/D71683