[PATCH] D71683: [ORC][EH] Deregister EH frames in MemoryManager dtor

[Lang Hames via Phabricator via llvm-commits]

lhames added a comment.

Actually, are you seeing this bug on ORC? Or just on MCJIT?

Looking at the code again, if you're using ORC this should be handled automatically. If you're using MCJIT it is (unfortunately) contract that you're responsible for calling this yourself. It would be safe to add this call to SectionMemoryManager as redundant calls (from existing clients) are no-ops, but it introduces a hazard: Anyone who brings up a JIT successfully with SectionMemoryManager is suddenly going to discover that their code fails when they try to use a custom memory manager.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71683/new/

https://reviews.llvm.org/D71683