[PATCH] D71786: RFC: [Support] On Windows, add optional support for rpmalloc

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 20 17:01:31 PST 2019


amccarth added a comment.

Just a nit on the patch description:  This change replaces the CRT allocator (i.e., malloc and free).  The "default Windows heap allocator" could be misunderstood to mean replacing the OS-level heap manager (i.e., https://docs.microsoft.com/en-us/windows/win32/memory/heap-functions).

The code comments are clear.  It's just the beginning of the patch description that could throw someone off.

This changes the memory stack from:

new/delete -> MS VC++ CRT malloc/free -> HeapAlloc -> VirtualAlloc

to

new/delete -> rpmalloc -> VirtualAlloc


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71786/new/

https://reviews.llvm.org/D71786





More information about the llvm-commits mailing list