[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

Fri Dec 20 16:39:48 PST 2019

leonardchan added a comment.

Hi! This seems to be causing some test failures on our bots: https://ci.chromium.org/p/fuchsia/builders/ci/clang-linux-x64/b8893521019883752048

  : 'RUN: at line 553';   /b/s/w/ir/k/recipe_cleanup/clangciZYdn/llvm_build_dir/bin/clang -### -target hexagon-unknown-elf    -ccc-install-dir /b/s/w/ir/k/llvm-project/clang/test/Driver/Inputs/hexagon_tree/Tools/bin    -mcpu=hexagonv60    -fuse-ld=lld    /b/s/w/ir/k/llvm-project/clang/test/Driver/hexagon-toolchain-elf.c 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangciZYdn/llvm_build_dir/bin/FileCheck -check-prefix=CHECK082 /b/s/w/ir/k/llvm-project/clang/test/Driver/hexagon-toolchain-elf.c
  --
  Exit Code: 1

  Command Output (stderr):
  --
  /b/s/w/ir/k/llvm-project/clang/test/Driver/hexagon-toolchain-elf.c:548:14: error: CHECK081: expected string not found in input
  // CHECK081: "-march=hexagon"
               ^
  <stdin>:1:1: note: scanning from here
  Fuchsia clang version 10.0.0 (https://fuchsia.googlesource.com/a/third_party/llvm-project ddf897fc80499ece298bc33201db6b697d2af50e)
  ^
  <stdin>:5:193: note: possible intended match here
   "/b/s/w/ir/k/recipe_cleanup/clangciZYdn/llvm_build_dir/bin/clang-10" "-cc1" "-triple" "hexagon-unknown-unknown-elf" "-emit-obj" "-mrelax-all" "--mrelax-relocations" "-disable-free" "-main-file-name" "hexagon-toolchain-elf.c" "-mrelocation-model" "static" "-mthread-model" "posix" "-mframe-pointer=all" "-fmath-errno" "-fno-rounding-math" "-masm-verbose" "-mconstructor-aliases" "-target-cpu" "hexagonv60" "-target-feature" "-long-calls" "-mqdsp6-compat" "-Wreturn-type" "-fshort-enums" "-mllvm" "-machine-sink-split=0" "-dwarf-column-info" "-fno-split-dwarf-inlining" "-debugger-tuning=gdb" "-resource-dir" "/b/s/w/ir/k/recipe_cleanup/clangciZYdn/llvm_build_dir/lib/clang/10.0.0" "-internal-externc-isystem" "/b/s/w/ir/k/llvm-project/clang/test/Driver/Inputs/hexagon_tree/Tools/bin/../target/hexagon/include" "-fdebug-compilation-dir" "/b/s/w/ir/k/recipe_cleanup/clangciZYdn/llvm_build_dir/tools/clang/test/Driver" "-ferror-limit" "19" "-fmessage-length" "0" "-fshort-enums" "-fno-signed-char" "-fgnuc-version=4.2.1" "-fobjc-runtime=gcc" "-fdiagnostics-show-option" "-faddrsig" "-o" "/b/s/w/ir/tmp/t/hexagon-toolchain-elf-2999dd.o" "-x" "c" "/b/s/w/ir/k/llvm-project/clang/test/Driver/hexagon-toolchain-elf.c"
                                                                                                                                                                                                  ^

  --

  ********************
  Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 

  Testing Time: 60.03s
  ********************
  Failing Tests (1):
      Clang :: Driver/hexagon-toolchain-elf.c

Would you mind taking a look and either fixing or reverting this patch? Thanks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70919/new/

https://reviews.llvm.org/D70919