[PATCH] D71738: [lld][WebAssembly] Add libcall symbols to the link when LTO is being used.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 20 13:37:31 PST 2019


pcc added inline comments.


================
Comment at: lld/wasm/Driver.cpp:450
+    MemoryBufferRef mb = lazySym->getMemberBuffer();
+    if (isBitcode(mb))
+      lazySym->fetch();
----------------
Do you really need the `isBitcode` check in the wasm linker? We needed it in the ELF linker because of some badly behaving libgcc functions, but maybe wasm doesn't have anything like that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71738/new/

https://reviews.llvm.org/D71738





More information about the llvm-commits mailing list