[PATCH] D71772: [scudo][standalone] Support __BIONIC__

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 20 10:40:02 PST 2019


cryptoad updated this revision to Diff 234923.
cryptoad added a comment.

New proposal as per Peter's suggestion: include `stdint.h` in
`platform.h` and check for `__BIONIC__`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71772/new/

https://reviews.llvm.org/D71772

Files:
  compiler-rt/lib/scudo/standalone/platform.h


Index: compiler-rt/lib/scudo/standalone/platform.h
===================================================================
--- compiler-rt/lib/scudo/standalone/platform.h
+++ compiler-rt/lib/scudo/standalone/platform.h
@@ -9,13 +9,17 @@
 #ifndef SCUDO_PLATFORM_H_
 #define SCUDO_PLATFORM_H_
 
+// Transtive includes of stdint.h specify some of the defines checked below.
+#include <stdint.h>
+
 #if defined(__linux__)
 #define SCUDO_LINUX 1
 #else
 #define SCUDO_LINUX 0
 #endif
 
-#if defined(__ANDROID__)
+// See https://android.googlesource.com/platform/bionic/+/master/docs/defines.md
+#if defined(__BIONIC__)
 #define SCUDO_ANDROID 1
 #else
 #define SCUDO_ANDROID 0


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71772.234923.patch
Type: text/x-patch
Size: 667 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191220/d823b9b6/attachment.bin>


More information about the llvm-commits mailing list