[PATCH] D70450: [AArch64] Teach Load/Store optimizier to rename store operands for pairing.
Danilo Carvalho Grael via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 20 10:29:45 PST 2019
dancgr added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:897
+ assert(MOP.isImplicit() ||
+ (MOP.isRenamable() && !MOP.isEarlyClobber()) &&
+ "Need renamable operands");
----------------
This creates a warning when compiling in debug mode for me.
Did you mean to use this?
```
assert(MOP.isImplicit() ||
(MOP.isRenamable() && !MOP.isEarlyClobber()) &&
"Need renamable operands");
```
It looks like this code is missing brackets wrapping the logical condition, like the ones from from line 886 assertion.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70450/new/
https://reviews.llvm.org/D70450
More information about the llvm-commits
mailing list