[PATCH] D71735: [ELF] Don't suggest an alternative spelling for a symbol in a discarded section

[Fangrui Song via Phabricator via llvm-commits]

MaskRay marked 2 inline comments as done.
MaskRay added inline comments.


================
Comment at: lld/test/ELF/undef-not-suggest.s:1
+# REQUIRES: riscv
+## Check we don't suggest alternative spelling for relocations to symbols
----------------
grimar wrote:
> I wonder if we should use yaml2obj (if possible) and make this test be not 'riscv' specific?
A yaml2obj test will degrade test coverage.

```
Symbols:
  - Name:    foo
    Section: .text.foo
  - Name:    for
    Section: .data
  - Name:    .text.foo
    Type:    STT_SECTION
    Section: .text.foo
### This symbol's name is ".data", instead of "" as produced by an assembler.
### We need a symbol with empty name for the `.quad .text.foo` test, to test that an empty name will not be suggested.
  - Name:    .data
    Type:    STT_SECTION
    Section: .data
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71735/new/

https://reviews.llvm.org/D71735