[PATCH] D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging
Paolo Severini via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 20 10:09:52 PST 2019
paolosev added inline comments.
================
Comment at: lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp:45
+
+/// Reads a LEB128 variable-length unsigned integer, limited to 7 bits.
+llvm::Optional<uint8_t> GetVaruint7(DataExtractor §ion_header_data,
----------------
aprantl wrote:
> The LLVM coding style requests that doxygen comments should be on the declaration in the header file and not in the implementation.
This function is not declared in the header. Probably it doesn't need a doxygen comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71575/new/
https://reviews.llvm.org/D71575
More information about the llvm-commits
mailing list