[PATCH] D71710: [instrinsics] Add @llvm.memcpy.inline instrinsics

Fri Dec 20 08:39:27 PST 2019

gchatelet added a comment.

In D71710#1791589 <https://reviews.llvm.org/D71710#1791589>, @jdoerfert wrote:

> This looks pretty reasonable to me. Test coverage is low though:
>  I think we need to add it to the read/write intrinsic tests (that I thought existed). Also some tests that verify we handle memcpy in a certain way should be copied for this intrinsic.

Thx for the review @jdoerfert. I tried to add the relevant tests, do you have any other tests in mind?

================
Comment at: llvm/include/llvm/IR/Intrinsics.td:512
+      ImmArg<2>, ImmArg<3> ]>;
+
 //===------------------- Standard C Library Intrinsics --------------------===//
----------------
jdoerfert wrote:
> Nit: I'd move this below just after the non-inline version.
> 
> 
Ok although it's not part of the 'Standard C Library Intrinsics' per say.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71710/new/

https://reviews.llvm.org/D71710