[PATCH] D71763: [yaml2obj] - Add testing for OSABI field.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 20 07:18:27 PST 2019


grimar added a comment.

In D71763#1792797 <https://reviews.llvm.org/D71763#1792797>, @grimar wrote:

> In D71763#1792782 <https://reviews.llvm.org/D71763#1792782>, @jhenderson wrote:
>
> > This is fine, but I wonder what you think about testing using `od`, to avoid things being circular here? Presumably you will use yaml2obj to test llvm-readobj prints the right value for the field, which means that theoretically, both could be broken in the same way and we wouldn't notice.
>


Ok, I see a possbile scenario now. Like yaml2obj writes `X` instead of `Y` and then readelf reads `X` and shows `Y`. But that way we should use `od` everywhere and verify `od` with other tools too, because `od` might be broken in the same way too :) It is too much probably?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71763/new/

https://reviews.llvm.org/D71763





More information about the llvm-commits mailing list