[PATCH] D70900: [Matrix] Propagate and use shape information for loads.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 20 05:50:14 PST 2019


fhahn updated this revision to Diff 234873.
fhahn added a comment.

- [Matrix] Propagate and use shape information for loads.

> I am confused about this patch and the previous one (D70899 <https://reviews.llvm.org/D70899>). Looks like they both introduce VisitLoad. Is this intentional?

No, it looks like I did not update D70899 <https://reviews.llvm.org/D70899> after this one. I've updated the D70899 <https://reviews.llvm.org/D70899> to not include the load lowering changes and updated the tests to only show the changes.

TO make that easier I adjusted computeColumnAddr to give the values more meaningful names.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70900/new/

https://reviews.llvm.org/D70900

Files:
  llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp
  llvm/test/Transforms/LowerMatrixIntrinsics/bigger-expressions-double.ll
  llvm/test/Transforms/LowerMatrixIntrinsics/propagate-backward.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70900.234873.patch
Type: text/x-patch
Size: 58370 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191220/3e01c04a/attachment.bin>


More information about the llvm-commits mailing list