[PATCH] D71747: [llvm-objdump][llvm-readobj] - Refactor dynamic tags dumping.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

This change isn't a refactor, and it seems to cover multiple different issues. I think it needs breaking up:

1. Fix the spacing.
2. Improve the printing of unknown tags (I assume the GNU style matches GNU readelf's output?).
3. Improve the testing.
4. Any other refactor (i.e. no functional changes) to support the above.

I'm happy for these to be in any order that makes sense, but as things stand, I don't feel confident in reviewing it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71747/new/

https://reviews.llvm.org/D71747