[PATCH] D71697: [llvm-readobj] - Merge `gnu-symbols.test` to `symbols.test` and cleanup.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/symbols.test:69
+# NO-T-ERR: Unknown command line argument '-t'
+## -s is a llvm-readobj option to dump sections.
+# RUN: llvm-readobj -s --elf-output-style=GNU %t64 | FileCheck %s --implicit-check-not="Symbol table"
----------------
MaskRay wrote:
> jhenderson wrote:
> > I //think// this should be "is an llvm-readobj".
> (Slightly OT: I use "an R_*_IRELATIVE". I hope I used it correctly:) )
> (Slightly OT: I use "an R_*_IRELATIVE". I hope I used it correctly:) )
(I think you do. I think the rule is that words starting with a vowel sound, which includes words where you spell out a letter at the start individually use "an". Example - you'd say "ar_..." for "R_*_IRELATIVE, or "el-el-vee-em" for llvm-*)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71697/new/

https://reviews.llvm.org/D71697