[PATCH] D71656: [DAGCombiner] Check term use before applying aggressive FSUB optimisation

[Carl Ritson via Phabricator via llvm-commits]

critson added a comment.

In D71656#1790846 <https://reviews.llvm.org/D71656#1790846>, @foad wrote:

> Looks like this case was missed in rL291642 <https://reviews.llvm.org/rL291642>. Is it worth checking the other cases too, e.g. the next one at line 11896? Can you add your test to `fadd-fma-fmul-combine.ll` instead of creating a new test file?


Thanks for pointing this out.  I'll review the other cases and integrate the tests into the same file.  It looks like the test I created is just a mirror of the previous test with LHS and RHS swapped.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71656/new/

https://reviews.llvm.org/D71656