[PATCH] D71570: [CMake] Prefer multi-target variables over generic target variables in runtimes build

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 19 17:19:56 PST 2019


phosek added a comment.

In D71570#1792087 <https://reviews.llvm.org/D71570#1792087>, @phosek wrote:

> I'm fine with this change in general, but I'm concerned that no matter what order we choose, this might break users who rely on the opposite order.  Maybe it'd be better to modify the logic to skip the second loop if the first loop matches, that way we wouldn't rely on any particular order.


I've implemented the proposed idea in D71737 <https://reviews.llvm.org/D71737>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71570/new/

https://reviews.llvm.org/D71570





More information about the llvm-commits mailing list