[PATCH] D70951: [Matrix] Use fmuladd when lowering matrix.multiply.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 19 15:50:16 PST 2019


fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:50
+             "result in different results, due to less rounding error."));
+
 namespace {
----------------
anemet wrote:
> Shouldn't this be using the fpflags from the intrinsic?  I.e. I was thinking of a clang flag.
We can certainly add this on the clang level, although I am not sure how easy/hard it will be to add additional flags there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70951/new/

https://reviews.llvm.org/D70951





More information about the llvm-commits mailing list