[PATCH] D71219: Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of swift and Objective-C bitcode

[Steven Wu via Phabricator via llvm-commits]

steven_wu added a comment.

> 
> 
> 1. I will add a  llvm-link tests for combining objc and swift bitcode.
> 2. What do you mean by "codegen tests for correct value in the object file"? There is no "object file" in the picture. Are you asking for a test that checks the value in the output of llvm-link?

I think the decision was to break apart the current "Objective-C Garbage Collection" metadata. You need codegen test to test that OBJC_IMAGE_INFO is generated correctly after breaking apart the value.

> 3. Let us keep the auto upgrade to a different future diff to keep each diff self contained. Is that ok?

I disagree with that. That is leaving a gap for incompatible bitcode.

Steven


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71219/new/

https://reviews.llvm.org/D71219