[PATCH] D71667: [XCOFF][AIX] Fix for missing of undefined symbols from symbol table

[David Tenty via Phabricator via llvm-commits]

daltenty added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-toc.ll:73
 ; SYM:       File: {{.*}}aix-xcoff-toc.ll.tmp.o
-; SYM:       Symbol {{[{][[:space:]] *}}Index: [[#INDX:]]{{[[:space:]] *}}Name: TOC
+; SYM:       Symbol {{[{][[:space:]] *}}Index: [[#UNDEF_INDX:]]{{[[:space:]] *}}Name: a
+; SYM-NEXT:   Value (RelocatableAddress): 0x0
----------------
My only concern here is that maybe these don't belong in this testcase. This test case tests exclusively TOC related functionality currently. Perhaps adding an undef test would be better (and possibly folding some of the undef function tests into it).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71667/new/

https://reviews.llvm.org/D71667