[PATCH] D71719: [scudo][standalone] Implement TSD registry disabling

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 19 12:03:50 PST 2019


cryptoad updated this revision to Diff 234763.
cryptoad added a comment.

Use an `atomic_u8` for `Disabled` in the Exclusive Registry.
This should ensure that changes to the variable are visible to the
threads in a somewhat timely manner.

A run on rpc2-benchmark with this new change does show noticeable
performance degradation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71719/new/

https://reviews.llvm.org/D71719

Files:
  compiler-rt/lib/scudo/standalone/combined.h
  compiler-rt/lib/scudo/standalone/flags.cpp
  compiler-rt/lib/scudo/standalone/tests/wrappers_c_test.cpp
  compiler-rt/lib/scudo/standalone/tsd_exclusive.h
  compiler-rt/lib/scudo/standalone/tsd_shared.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71719.234763.patch
Type: text/x-patch
Size: 4412 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191219/bb867bdb/attachment.bin>


More information about the llvm-commits mailing list