[PATCH] D71710: [instrinsics] Add @llvm.memcpy.inline instrinsics
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 19 11:43:02 PST 2019
jdoerfert added a comment.
This looks pretty reasonable to me. Test coverage is low though:
I think we need to add it to the read/write intrinsic tests (that I thought existed). Also some tests that verify we handle memcpy in a certain way should be copied for this intrinsic.
================
Comment at: llvm/include/llvm/IR/Intrinsics.td:512
+ ImmArg<2>, ImmArg<3> ]>;
+
//===------------------- Standard C Library Intrinsics --------------------===//
----------------
Nit: I'd move this below just after the non-inline version.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71710/new/
https://reviews.llvm.org/D71710
More information about the llvm-commits
mailing list