[PATCH] D71660: [ValueTracking] isKnownNonZero() should take non-null-ness assumptions into consideration (PR43267)

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM. One suggestion below.

FWIW. The way I read the comments by @nikic, I think this can be pushed.



================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:648
+  return false;
+}
+
----------------
I'd move the `isValidAssumeForContext(I, Q.CxtI, Q.DT)` as early as possible, assuming I haven't overlooked a case where it is not called.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71660/new/

https://reviews.llvm.org/D71660