[PATCH] D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions

Thu Dec 19 10:54:24 PST 2019

jinlin added a comment.

In D71217#1775913 <https://reviews.llvm.org/D71217#1775913>, @tellenbach wrote:

> As @lebedev.ri already said, is it possible to add a test for this? I know it is probably covered in your test for D71027 <https://reviews.llvm.org/D71027> but an independent test would be great!

Hi David, a standalone test would be ideal, but it is extremely difficult to come up with such a test case. I have spent many days thinking about a test case for this incorrect logic.
Given the end of the workflow where it happen, exposing the bug is quite difficult. 
Under such circumstance, it would not be prudent to get blocked on a test case. The outline-repeat feature exercises the need for this fix and a test case added there serves the purpose. 
Hope you can understand and sympathize with me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71217/new/

https://reviews.llvm.org/D71217