[llvm] ba430f5 - [cmake] Add dependency on llvm-dwarfdump to llvm-locstats

[David Spickett via llvm-commits]

Author: David Spickett
Date: 2019-12-19T16:36:14Z
New Revision: ba430f503244d1498529d47f31090cdf79b5c231

URL: https://github.com/llvm/llvm-project/commit/ba430f503244d1498529d47f31090cdf79b5c231
DIFF: https://github.com/llvm/llvm-project/commit/ba430f503244d1498529d47f31090cdf79b5c231.diff

LOG: [cmake] Add dependency on llvm-dwarfdump to llvm-locstats

Though llvm-locstat is a "util" it requires llvm-dwarfdump
to be useful. So what happens now is that unless LLVM_BUILD_TOOLS
is ON llvm-locstats won't be part of the "all" target.

However given that it requires llvm-dwarfdump, this is less
confusing/build time consuming than suddenly having llvm-dwarfdump
build when all other tools are disabled.

Differential Revision: https://reviews.llvm.org/D71705

Added: 
    

Modified: 
    llvm/utils/llvm-locstats/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/llvm/utils/llvm-locstats/CMakeLists.txt b/llvm/utils/llvm-locstats/CMakeLists.txt
index d5366f99050f..1dbb9da92e23 100644
--- a/llvm/utils/llvm-locstats/CMakeLists.txt
+++ b/llvm/utils/llvm-locstats/CMakeLists.txt
@@ -2,11 +2,15 @@ if (LLVM_INCLUDE_UTILS AND LLVM_INCLUDE_TOOLS)
   add_custom_command(
     OUTPUT ${LLVM_TOOLS_BINARY_DIR}/llvm-locstats
     DEPENDS ${LLVM_MAIN_SRC_DIR}/utils/llvm-locstats/llvm-locstats.py
+    DEPENDS llvm-dwarfdump
     COMMAND ${CMAKE_COMMAND} -E copy ${LLVM_MAIN_SRC_DIR}/utils/llvm-locstats/llvm-locstats.py ${LLVM_TOOLS_BINARY_DIR}/llvm-locstats
     COMMENT "Copying llvm-locstats into ${LLVM_TOOLS_BINARY_DIR}"
     )
   add_custom_target(llvm-locstats ALL
     DEPENDS ${LLVM_TOOLS_BINARY_DIR}/llvm-locstats
     )
+  if (NOT LLVM_BUILD_TOOLS)
+    set_target_properties(llvm-locstats PROPERTIES EXCLUDE_FROM_ALL ON)
+  endif()
   set_target_properties(llvm-locstats PROPERTIES FOLDER "Tools")
 endif()