[PATCH] D71705: [cmake] Add dependency on llvm-dwarfdump to llvm-locstats

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 19 07:32:47 PST 2019


djtodoro added a comment.

Please make sure the tool name is `llvm-locstats` instead of `llvm-covstat`.

(This patch is follow up for the https://reviews.llvm.org/D71695, where is the rest of the conversation).



================
Comment at: llvm/utils/llvm-locstats/CMakeLists.txt:12
     )
+  if (NOT LLVM_BUILD_UTILS)
+    set_target_properties(llvm-locstats PROPERTIES EXCLUDE_FROM_ALL ON)
----------------
Please describe, once again, why you decided to use the `LLVM_BUILD_UTILS` instead of the `LLVM_BUILD_TOOLS` here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71705/new/

https://reviews.llvm.org/D71705





More information about the llvm-commits mailing list