[PATCH] D69563: [LV] Strip wrap flags from vectorized reductions
Ayal Zaks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 19 04:40:10 PST 2019
Ayal accepted this revision.
Ayal added a comment.
This revision is now accepted and ready to land.
This looks good to me, with couple of final nits; thanks!
================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:534
+ /// Clear NSW/NUW flags from reduction instructions if necessary
+ void clearReductionWrapFlags(RecurrenceDescriptor &RdxDesc);
----------------
nit: end above sentence with period.
================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:3873
+ Instruction *LoopExitInstr = RdxDesc.getLoopExitInstr();
+ assert(LoopExitInstr != nullptr && "null loop exit instruction");
+ SmallVector<Instruction *, 8> Worklist;
----------------
nit: can shorten to `assert(LoopExitInstr && "null loop exit instruction");`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69563/new/
https://reviews.llvm.org/D69563
More information about the llvm-commits
mailing list