[PATCH] D71695: [cmake] Include the llvm-locstats target when utils and tools are not being built.

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 19 02:30:18 PST 2019


DavidSpickett created this revision.
DavidSpickett added reviewers: djtodoro, dstenb.
Herald added subscribers: llvm-commits, mgorny.
Herald added a project: LLVM.

This was uncovered by: https://reviews.llvm.org/D71611
Which added llvm-locstats to the test dependencies.

Previously the build target was only added if you 
were building tools. This meant that you couldn't
configure at all if you had LLVM_BUILD_TOOLS=OFF.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D71695

Files:
  llvm/utils/llvm-locstats/CMakeLists.txt


Index: llvm/utils/llvm-locstats/CMakeLists.txt
===================================================================
--- llvm/utils/llvm-locstats/CMakeLists.txt
+++ llvm/utils/llvm-locstats/CMakeLists.txt
@@ -1,4 +1,4 @@
-if (LLVM_BUILD_UTILS AND LLVM_BUILD_TOOLS)
+if (LLVM_INCLUDE_UTILS AND LLVM_INCLUDE_TOOLS)
   add_custom_command(
     OUTPUT ${LLVM_TOOLS_BINARY_DIR}/llvm-locstats
     DEPENDS ${LLVM_MAIN_SRC_DIR}/utils/llvm-locstats/llvm-locstats.py


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71695.234685.patch
Type: text/x-patch
Size: 456 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191219/94742de0/attachment.bin>


More information about the llvm-commits mailing list