[PATCH] D69808: [RISCV GlobalISel] Add lowerReturn for calling conv.

[weiwei via Phabricator via llvm-commits]

wwei marked 2 inline comments as done.
wwei added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVCallLowering.cpp:55
+    if (AssignFn)
+      return AssignFn(ValNo, ValVT, LocVT, LocInfo, Flags, State);
+    return false;
----------------
lewis-revill wrote:
> What's the case where this will be used? 
This is a reserved case. Currently, riscv backend does not implement `CCAssignFnForCall` and `CCAssignFnForReturn` , so `AssignFn` will be always null. If these two functions will be added later, the code is available directly.


================
Comment at: llvm/test/CodeGen/RISCV/GlobalISel/irtranslator-calllowering.ll:1
 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
 ; RUN: llc -mtriple=riscv32 -global-isel -stop-after=irtranslator -verify-machineinstrs < %s \
----------------
lewis-revill wrote:
> Nitpick: no longer true with these additions.
I don't understand why many test files add this assertion. So is your suggestion that we can remove this assertion?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69808/new/

https://reviews.llvm.org/D69808