[PATCH] D71389: [ConstantFold][SVE] Fix constant folding for bitcast.

[Huihui Zhang via Phabricator via llvm-commits]

huihuiz updated this revision to Diff 234639.
huihuiz marked 4 inline comments as done.
huihuiz edited the summary of this revision.
huihuiz added a comment.

Clean up code based on reviewer feedback.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71389/new/

https://reviews.llvm.org/D71389

Files:
  llvm/lib/IR/ConstantFold.cpp
  llvm/test/Analysis/ConstantFolding/bitcast.ll


Index: llvm/test/Analysis/ConstantFolding/bitcast.ll
===================================================================
--- /dev/null
+++ llvm/test/Analysis/ConstantFolding/bitcast.ll
@@ -0,0 +1,12 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt < %s -constprop -S -verify | FileCheck %s
+
+define <vscale x 4 x float> @bitcast_scalable_constant() {
+; CHECK-LABEL: @bitcast_scalable_constant(
+; CHECK-NEXT:    ret <vscale x 4 x float> shufflevector (<vscale x 4 x float> insertelement (<vscale x 4 x float> undef, float 0x36A0000000000000, i32 0), <vscale x 4 x float> undef, <vscale x 4 x i32> zeroinitializer)
+;
+  %i1 = insertelement <vscale x 4 x i32> undef, i32 1, i32 0
+  %i2 = shufflevector <vscale x 4 x i32> %i1, <vscale x 4 x i32> undef, <vscale x 4 x i32> zeroinitializer
+  %i3 = bitcast <vscale x 4 x i32> %i2 to <vscale x 4 x float>
+  ret <vscale x 4 x float> %i3
+}
Index: llvm/lib/IR/ConstantFold.cpp
===================================================================
--- llvm/lib/IR/ConstantFold.cpp
+++ llvm/lib/IR/ConstantFold.cpp
@@ -47,6 +47,11 @@
   if (CV->isAllOnesValue()) return Constant::getAllOnesValue(DstTy);
   if (CV->isNullValue()) return Constant::getNullValue(DstTy);
 
+  // Do not iterate on scalable vector. The num of elements is unknown at
+  // compile-time.
+  if (DstTy->isScalable())
+    return nullptr;
+
   // If this cast changes element count then we can't handle it here:
   // doing so requires endianness information.  This should be handled by
   // Analysis/ConstantFolding.cpp
@@ -563,6 +568,29 @@
       if (isAllNull)
         // This is casting one pointer type to another, always BitCast
         return ConstantExpr::getPointerCast(CE->getOperand(0), DestTy);
+    } else if (CE->getType()->isVectorTy() && DestTy->isVectorTy() &&
+               CE->getType()->getVectorElementCount() ==
+                   DestTy->getVectorElementCount() &&
+               CE->getOpcode() == Instruction::ShuffleVector &&
+               opc == Instruction::BitCast) {
+      // For splat vector, fold bitcast to splat value.
+      // BitCast(ShuffleVector(InsertElement(C1, SplatV, Zero), C2, Zero)) to NewType
+      // into
+      // ShuffleVector(InsertElement(C1, BitCast(SplatV) to NewType, Zero), C2, Zero)
+      Constant *SplatV, *C1, *C2, *ZeroIdx, *ZeroMask;
+      if (match(CE, m_ShuffleVector(
+                        m_InsertElement(
+                            m_Constant(C1), m_Constant(SplatV),
+                            m_CombineAnd(m_Zero(), m_Constant(ZeroIdx))),
+                        m_Constant(C2),
+                        m_CombineAnd(m_Zero(), m_Constant(ZeroMask))))) {
+        auto *CastedSplatV =
+            ConstantExpr::getCast(opc, SplatV, DestTy->getScalarType());
+        return ConstantExpr::getShuffleVector(
+            ConstantExpr::getInsertElement(
+                ConstantExpr::getCast(opc, C1, DestTy), CastedSplatV, ZeroIdx),
+            ConstantExpr::getCast(opc, C2, DestTy), ZeroMask);
+      }
     }
   }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71389.234639.patch
Type: text/x-patch
Size: 3068 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191219/ed058803/attachment.bin>