[PATCH] D69563: [LV] Strip wrap flags from vectorized reductions

[Denis Antrushin via Phabricator via llvm-commits]

dantrushin marked 2 inline comments as done.
dantrushin added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:3891
+  Instruction *LoopExitInstr = RdxDesc.getLoopExitInstr();
+  assert(LoopExitInstr != nullptr && "null loop exit instruction");
+  SmallVector<Instruction *, 8> Worklist;
----------------
Ayal wrote:
> There's no need to deal with LoopExitInstr in this implementation; it's probably clearer to start from the Phi as in the original version.
I'm passing `RecurrenceDescriptor` to this function
(so I can easily check reduction type here).
I only can get loop exit instruction from it, not Phi. 
Here I need *any* reduction instruction to start with, and I don't see much difference between `Phi` and `LoopExitInstr`. 

Do you want me to pass in Phi instead and check reduction type at call site? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69563/new/

https://reviews.llvm.org/D69563