[PATCH] D71144: [AIX] Use csect reference for function address constants

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1769
+          F->isDeclaration() ? XCOFF::XTY_ER : XCOFF::XTY_SD,
+          F->isDeclaration() ? SC : XCOFF::C_HIDDEN,
+          SectionKind::getMetadata());
----------------
`SC` is calculated, but not necessarily used. It probably makes sense to move the conditional to where `SC` is set.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-reference-func-addr-const.ll:2
+; RUN: llc -verify-machineinstrs -mcpu=pwr7 -mtriple powerpc-ibm-aix-xcoff < %s | FileCheck %s
+; RUN: llc -verify-machineinstrs -mcpu=pwr7 -mtriple powerpc64-ibm-aix-xcoff < %s | FileCheck --check-prefix=CHECK64 %s
+
----------------
This still says `pwr7`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71144/new/

https://reviews.llvm.org/D71144