[PATCH] D71629: [SystemZ] Recognize mrecord-mcount in backend

Jonas Paulsson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 18 10:00:34 PST 2019


jonpa updated this revision to Diff 234565.
jonpa marked 4 inline comments as done.
jonpa added a comment.

Patch updated per review.

Beginning to understand how this is supposed to work now, but still not sure why the text assembly looks ok, while I see with objdump --filetype=obj the new section filled with zeros:

  llc llvm/test/CodeGen/SystemZ/mrecord-mcount-01.ll -mtriple=s390x-linux-gnu -mcpu=z10 -o out.o --filetype=obj; objdump -D -z out.o
  
  0000000000000000 <__mcount_loc>:
  0:   00 00 00 00             .long   0x00000000
  4:   00 00 00 00             .long   0x00000000
  8:   00 00 00 00             .long   0x00000000
  c:   00 00 00 00             .long   0x00000000

I was expecting to see something like <test1> and <test2> somwhere there... Will the linker fix this somehow (not sure how it could since it's just zeroes...)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71629/new/

https://reviews.llvm.org/D71629

Files:
  llvm/lib/Target/SystemZ/SystemZAsmPrinter.cpp
  llvm/lib/Target/SystemZ/SystemZISelDAGToDAG.cpp
  llvm/test/CodeGen/SystemZ/mrecord-mcount-01.ll
  llvm/test/CodeGen/SystemZ/mrecord-mcount-02.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71629.234565.patch
Type: text/x-patch
Size: 3636 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191218/73f16aca/attachment.bin>


More information about the llvm-commits mailing list