[PATCH] D71660: [ValueTracking] isKnownNonZero() should take non-null-ness assumptions into consideration (PR43267)

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

I think the code looks fine. (One minor comment inlined).

I will not accept because of the placement discussion. I have not strong opinion (yet) as long as we make sure not only LVI can use this.



================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:623
+        return true;
+    }
+  }
----------------
< is also fine, however unlikely.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71660/new/

https://reviews.llvm.org/D71660