[PATCH] D70570: [PowerPC] Only use PLT annotations if using PIC relocation model
Sean Fertile via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 18 08:23:18 PST 2019
sfertile added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:5130
- bool UsePlt = Subtarget.is32BitELFABI() && !isLocalCallee();
+ bool UsePlt = Subtarget.is32BitELFABI() && !isLocalCallee() &&
+ Subtarget.getTargetMachine().getRelocationModel() == Reloc::PIC_;
----------------
Minor nit: I belive clang-format will produce a different indentation for this. can you run that before committing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70570/new/
https://reviews.llvm.org/D70570
More information about the llvm-commits
mailing list