[PATCH] D71660: [ValueTracking] isKnownNonZero() should take non-null-ness assumptions into consideration (PR43267)

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D71660#1789726 <https://reviews.llvm.org/D71660#1789726>, @nikic wrote:

> Have you considered integrating this in `isKnownNonNullFromDominatingCondition()` instead? It already iterates over all users of `V != 0` style conditions and could easily consider assumes in addition to branches.
>  That may be more efficient than handling it separately.


I'm not sure why it would be better than relying on the infrastructure specifically designed to handling assumptions?
It isn't obvious to me which approach is more performant, without benchmarks either approach may be much worse than the other one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71660/new/

https://reviews.llvm.org/D71660