[llvm] 3a779b7 - [globalisel] Small correction to the fixup in 0a0813962d6. The two ID's are not the same size

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 18 07:02:26 PST 2019


Author: Daniel Sanders
Date: 2019-12-18T14:56:23Z
New Revision: 3a779b7dfd8ee2924997dbed7f6c43d7989895f6

URL: https://github.com/llvm/llvm-project/commit/3a779b7dfd8ee2924997dbed7f6c43d7989895f6
DIFF: https://github.com/llvm/llvm-project/commit/3a779b7dfd8ee2924997dbed7f6c43d7989895f6.diff

LOG: [globalisel] Small correction to the fixup in 0a0813962d6. The two ID's are not the same size

The rule ID is a uint64_t as it has global scope but the UID is scoped to
the rule and expected to be much smaller so it's only unsigned.

Added: 
    

Modified: 
    llvm/utils/TableGen/GICombinerEmitter.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/utils/TableGen/GICombinerEmitter.cpp b/llvm/utils/TableGen/GICombinerEmitter.cpp
index aa733e260312..f30ae86c4fa0 100644
--- a/llvm/utils/TableGen/GICombinerEmitter.cpp
+++ b/llvm/utils/TableGen/GICombinerEmitter.cpp
@@ -291,7 +291,7 @@ static const DagInit *getDagWithOperatorOfSubClass(const Init &N,
 
 StringRef makeNameForAnonInstr(CombineRule &Rule) {
   return insertStrTab(to_string(
-      format("__anon%" PRIu64 "_%" PRIu64, Rule.getID(), Rule.allocUID())));
+      format("__anon%" PRIu64 "_%u", Rule.getID(), Rule.allocUID())));
 }
 
 StringRef makeDebugName(CombineRule &Rule, StringRef Name) {
@@ -300,7 +300,7 @@ StringRef makeDebugName(CombineRule &Rule, StringRef Name) {
 
 StringRef makeNameForAnonPredicate(CombineRule &Rule) {
   return insertStrTab(to_string(
-      format("__anonpred%" PRIu64 "_%" PRIu64, Rule.getID(), Rule.allocUID())));
+      format("__anonpred%" PRIu64 "_%u", Rule.getID(), Rule.allocUID())));
 }
 
 void CombineRule::declareMatchData(StringRef PatternSymbol, StringRef Type,


        


More information about the llvm-commits mailing list