[PATCH] D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions.

[Tom Weaver via Phabricator via llvm-commits]

TWeaver added a comment.

> Thanks for explaining, this makes sense to me. Any reason to not use `MI.isMetaInstruction()` as the guard? That would cause CFI/lifetime/EH_LABEL instructions to be skipped in addition to debug/kill instructions - would that be reasonable?

This suggestion makes sense to me, reading from the description of 'isMetaInstruction()' it would seem that it covers any instruction that doesn't produce any real output in the finished program.

I've tried this check and there's no new test failures and I feel satisfied that it's safe to do based on the description.

I've had to rework the comment suggestion from Adrian however as we're not ignoring any meta instruction rather than just debug intrinsics and KILL instructions.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70497/new/

https://reviews.llvm.org/D70497